Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Swallow ad blocker fetch fail #33617

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 22, 2022

I'm using uBlock Origin, which blocks this request. I suspect it's the case for more of our contributors:

Before

Screen.Recording.2022-07-23.at.00.35.58.mov

After

No error popup that interrupts the contribution workflow unnecessarily in development mode.


https://deploy-preview-33617--material-ui.netlify.app/material-ui/react-alert/

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Jul 22, 2022
@oliviertassinari oliviertassinari requested a review from a team July 22, 2022 22:46
@mui-bot
Copy link

mui-bot commented Jul 22, 2022

No bundle size changes

Generated by 🚫 dangerJS against 10086ab

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants